RFR: 8300543 Compiler Implementation for Pattern Matching for switch [v5]
Vicente Romero
vromero at openjdk.org
Fri Apr 21 16:52:57 UTC 2023
On Fri, 21 Apr 2023 16:25:04 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made final, together with updates to tests.
>> - parenthesized patterns are removed.
>> - qualified enum constants are supported for case labels.
>>
>> This change herein also includes removal record patterns in for each loop, which may be split into a separate PR in the future.
>
> Jan Lahoda has updated the pull request incrementally with two additional commits since the last revision:
>
> - Adding test.
> - Removing redundant continue, as noted on the review.
src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 315:
> 313: Object[] labels = resolvedLabels.resolvedLabels;
> 314:
> 315: // Dumbest possible strategy
I guess that given that we can't make any assumption about order here, this is the only possible strategy so I guess it makes sense to remove the comment
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13074#discussion_r1173981785
More information about the core-libs-dev
mailing list