RFR: 8306678: Replace use of os.version with an internal Version record

[Alan Bateman]

On Fri, 21 Apr 2023 16:44:13 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Create an internal Version record to hold and compare versions of the form (major, minor, micro).
> Add `OperatingSystem.version()` to return the version of the running OS.
> Replace uses of os.version in java.base.
> Subsequent PRs will apply to uses in other modules including, jdk.jlink, jdk.jpackage, and java.desktop.

src/java.base/macosx/classes/jdk/internal/loader/ClassLoaderHelper.java line 39:

> 37:         // SDK 10.15 and earlier always reports 10.16 instead of 11.x.x
> 38:         hasDynamicLoaderCache = OperatingSystem.version()
> 39:                 .compareTo(new Version(10, 16)) >= 0;

I wonder if this check can be removed too as 10.11 is the oldest macOS release that seems to be getting updates.

src/java.base/macosx/classes/sun/nio/fs/BsdFileStore.java line 103:

> 101:                 // fgetxattr broken on APFS prior to 10.14
> 102:                 return OperatingSystem.version()
> 103:                         .compareTo(new Version(10, 14)) >= 0;

I don't think 10.14 has had an updated since 2021 so I suspect you can just remove this check.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13584#discussion_r1173994111
PR Review Comment: https://git.openjdk.org/jdk/pull/13584#discussion_r1173992559