RFR: JDK-8304036: Use CommandLine class from shared module [v2]

[Mandy Chung]

On Fri, 21 Apr 2023 21:14:00 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> This pull request addresses the open ends left by [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919):
>> - #11272
>> 
>> Changes:
>> - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt` to `jdk.compiler` and `jdk.javadoc`
>> - [x] Use shared `CommandLine.java` in `jdk.compiler` module
>> - [x] Use shared `CommandLine.java` in `jdk.javadoc` module
>> - [x] Remove `CommandLine.java` from `jdk.compiler` module
>
> Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into JDK-8304036-reusable-command-line-part-2
>  - Add missing import
>  - JDK-8304036: Use CommandLine class from shared module

src/jdk.internal.opt/share/classes/module-info.java line 33:

> 31: module jdk.internal.opt {
> 32:     exports jdk.internal.joptsimple to jdk.jlink, jdk.jshell;
> 33:     exports jdk.internal.opt to jdk.compiler, jdk.jartool, jdk.javadoc, jdk.jlink, jdk.jpackage;

Nit: line break at each module is easier to read and avoid long line like:
   https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/module-info.java#L149

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12997#discussion_r1174181399