RFR: 8306698: Add overloads to MethodTypeDesc::of

[Chen Liang]

On Sun, 23 Apr 2023 13:06:34 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Please review this patch adding two new convenience methods that allows easier access to MethodTypeDesc instances and its associated CSR as well. This is a necessity to allow #13186 to reduce array copies in a few scenarios; the implementation of the two methods will be updated there.
>
> src/java.base/share/classes/java/lang/constant/MethodTypeDesc.java line 85:
> 
>> 83:      * @since 21
>> 84:      */
>> 85:     static MethodTypeDesc of(ClassDesc returnDesc, Collection<ClassDesc> paramDescs) {
> 
> This needs to be:
> Suggestion:
> 
>     static MethodTypeDesc of(ClassDesc returnDesc, List<ClassDesc> paramDescs) {
> 
> 
> as `Collection` doesn’t have a defined encounter order.

No, this is what List.copyOf supports.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13599#discussion_r1174609400