RFR: JDK-8304423: Refactor FdLibm.java
Raffaello Giulietti
rgiulietti at openjdk.org
Mon Apr 24 12:03:44 UTC 2023
On Sun, 23 Apr 2023 22:34:43 GMT, Joe Darcy <darcy at openjdk.org> wrote:
> Minor refactoring of FdLibm.java; will consider future refactorings with more substantive code changes in the future.
src/java.base/share/classes/java/lang/FdLibm.java line 76:
> 74: private static final int SIGN_BIT = 0x8000_0000;
> 75: private static final int EXP_BITS = 0x7ff0_0000;
> 76: private static final int EXP_SIGNIF_BITS = 0x7fff_ffff;
These could be expressed in terms of the constants in `Double`. But perhaps it's not worth doing so, after all, as the reader is assumed to be quite knowledgeable.
Otherwise LGTM.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13604#discussion_r1175183371
More information about the core-libs-dev
mailing list