RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v3]

Adam Sotona asotona at openjdk.org
Tue Apr 25 19:12:23 UTC 2023


On Mon, 24 Apr 2023 21:59:29 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Doc fixes + added null and empty tests
>
> src/java.base/share/classes/java/lang/constant/ModuleDesc.java line 30:
> 
>> 28: 
>> 29: /**
>> 30:  * A nominal descriptor for a {@code Module} constant {@jvms 4.4.11}.
> 
> This inlined link looks a bit awkward in the output.
> 
> I suggest to move `{@jvms 4.4.11}` as see also section before `@since 21`. See the suggestion below

Fixed, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13615#discussion_r1176927427


More information about the core-libs-dev mailing list