RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v3]

[Adam Sotona]

On Mon, 24 Apr 2023 22:05:18 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Doc fixes + added null and empty tests
>
> src/java.base/share/classes/java/lang/constant/ModuleDesc.java line 43:
> 
>> 41:      * given the name of the module.
>> 42:      *
>> 43:      * <p>{@jvms 4.2.3} Module names are not encoded in "internal form" like
> 
> I would avoid copying JVMS 4.2.3 into the javadoc as it might become out-of-sync.  In addition, adding `@jvms 4.2.3 Module and Package Names` in the see also section should be adequate (like the javadoc of `ClassDesc::ofInternalName`).

Fixed, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13615#discussion_r1176954238