RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v10]

Per Minborg pminborg at openjdk.org
Wed Apr 26 06:29:53 UTC 2023


On Tue, 25 Apr 2023 19:43:29 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Constants API already provides models for all loadable constants to help programs manipulating class files and modelling bytecode instructions. However no models of module and package constants are provided by Constants API. Every program manipulating class files must implement own models and validation of modules and packages constants.
>> 
>> This pul request adds `java.lang.constant.ModuleDesc` and `java.lang.constant.PackageDesc` to the Constants API. 
>> 
>> Classfile API will follow up and remove its internal implementations of `PackageDesc` and `ModuleDesc`. 
>> 
>> Please review this pull request and attached CSR.
>> 
>> Thank you,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update ModuleDesc.java
>  - Update PackageDesc.java

Have we considered moving the Impl classes into a non-public area such as `jdk.internal` to improve encapsulation and reduce perceived footprint?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13615#issuecomment-1522847163


More information about the core-libs-dev mailing list