RFR: 8298993: (process) java/lang/ProcessBuilder/UnblockSignals.java fails

Wed Apr 26 20:31:52 UTC 2023

On Tue, 25 Apr 2023 21:43:54 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> It appears that -Xcomp causes the relative timing of the commands to be disturbed enough to prevent the correct operation of the test. The test should not be run with -Xcomp

Changes requested by bchristi (Reviewer).

test/jdk/java/lang/ProcessBuilder/UnblockSignals.java line 32:

> 30:  * @requires (os.family == "linux" | os.family == "mac")
> 31:  * @comment Don't allow -Xcomp, it disturbs the relative timing of the sleep and kill commands
> 32:  * @requires (vm.compMode == "Xmixed")

How about `vm.compMode != "Xcomp"` ?

-------------

PR Review: https://git.openjdk.org/jdk/pull/13660#pullrequestreview-1402740951
PR Review Comment: https://git.openjdk.org/jdk/pull/13660#discussion_r1178349433