RFR: 8306711: Improve diagnosis of `IntlTest` framework [v3]
Justin Lu
jlu at openjdk.org
Wed Apr 26 23:42:52 UTC 2023
On Wed, 26 Apr 2023 20:08:51 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Move getErrorCount() back to original spot
>> - Regardles of nothrow, final result should be logged, cache, move method back
>
> Looks good overall perhaps consider using `HexFormat` instead of the private method `toHexString`
@LanceAndersen Thanks for the review. Changed it so that `HexFormat` methods are used, luckily only one subclass used `toHexString`.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13655#issuecomment-1524179840
More information about the core-libs-dev
mailing list