RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v3]
Jaikiran Pai
jpai at openjdk.org
Thu Apr 27 01:24:54 UTC 2023
On Thu, 30 Mar 2023 03:06:51 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array which is responsible for storing the compressed data is insufficient. And being unable to write whole compressed data on array, on s390 whole data can't be recovered after compression. This PR updates the check method in the DeInflate test to no longer rely on pre-defined lengths/sizes to determine whether deflate followed by an inflate of data worked correctly. These sizes can vary depending on the underlying zlib implementations. The updated check method now uses a `ByteArrayOutputStream` to deflate into and then inflate from.
>>
>> Thanks to @jaikiran for amazing PR description.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> removes out1,out2 parameters
Hello Lance,
> Jai, have you run this acrossed all of our Mach5 platforms?
Yes I did that yesterday and the tests were successful.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/12283#issuecomment-1524346331
More information about the core-libs-dev
mailing list