RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v5]
Andrey Turbanov
aturbanov at openjdk.org
Thu Apr 27 16:22:24 UTC 2023
On Thu, 27 Apr 2023 07:24:24 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array which is responsible for storing the compressed data is insufficient. And being unable to write whole compressed data on array, on s390 whole data can't be recovered after compression. This PR updates the check method in the DeInflate test to no longer rely on pre-defined lengths/sizes to determine whether deflate followed by an inflate of data worked correctly. These sizes can vary depending on the underlying zlib implementations. The updated check method now uses a `ByteArrayOutputStream` to deflate into and then inflate from.
>>
>> Thanks to @jaikiran for amazing PR description.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> comment suggestion from @jaikiran
test/jdk/java/util/zip/DeInflate.java line 146:
> 144: def.finish();
> 145:
> 146: try(ByteArrayOutputStream baos = new ByteArrayOutputStream(len)) {
Suggestion:
try (ByteArrayOutputStream baos = new ByteArrayOutputStream(len)) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12283#discussion_r1179401992
More information about the core-libs-dev
mailing list