RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v6]

Amit Kumar amitkumar at openjdk.org
Fri Apr 28 09:24:06 UTC 2023


On Fri, 28 Apr 2023 08:31:05 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changes request by @turbanoff
>
> test/jdk/java/util/zip/DeInflate.java line 164:
> 
>> 162:             out2 = baos.toByteArray();
>> 163:             if (n != len ||
>> 164:                 !Arrays.equals(Arrays.copyOf(in, len), Arrays.copyOf(out2, len)) ||
> 
> Instead of copying the arrays you can use `Arrays.equals(in, 0, len, out2, 0 len)`

>Sorry for not having seen this earlier. I'm somehow proficient with issues due to different zlib implementations and could have probably helped to push this trough a litter quicker :)

No issues, Next time I'll start by pinging you. 😀

Thanks for review & suggestion

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12283#discussion_r1180139453


More information about the core-libs-dev mailing list