RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v8]

Lance Andersen lancea at openjdk.org
Fri Apr 28 10:42:01 UTC 2023


On Fri, 28 Apr 2023 09:58:59 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> DeInflate.java test fails on s390x platform because size for out1 array which is responsible for storing the compressed data is insufficient. And being unable to write whole compressed data on array, on s390 whole data can't be recovered after compression. This PR updates the check method in the DeInflate test to no longer rely on pre-defined lengths/sizes to determine whether deflate followed by an inflate of data worked correctly. These sizes can vary depending on the underlying zlib implementations. The updated check method now uses a `ByteArrayOutputStream` to deflate into and then inflate from. 
>> 
>> Thanks to @jaikiran for amazing PR description.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removes extra closing paren.

I think this looks better.  The ByteArrayOutputStream on line 50 could also be wrapped in a try-with-resources and it would be nice to do that as part of this PR if possible

-------------

Marked as reviewed by lancea (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/12283#pullrequestreview-1405677627


More information about the core-libs-dev mailing list