RFR: JDK-8077371: Binary files in JAXP test should be removed [v4]

Joe Wang joehw at openjdk.org
Fri Apr 28 18:51:24 UTC 2023


On Thu, 27 Apr 2023 17:35:12 GMT, Mahendra Chhipa <mchhipa at openjdk.org> wrote:

>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented the review comments.

Looks ok. Probably note in the relevant data classes the origin of the data (the .ser file generated with the JDK version).

test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.

missed the original copyright year, e.g. 2014, 2023,

-------------

Marked as reviewed by joehw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13537#pullrequestreview-1406427199
PR Review Comment: https://git.openjdk.org/jdk/pull/13537#discussion_r1180715378


More information about the core-libs-dev mailing list