Integrated: 8304837: Classfile API throws IOOBE for MethodParameters attribute without parameter names

Hannes Greule duke at openjdk.org
Sat Apr 29 08:05:56 UTC 2023


On Thu, 23 Mar 2023 19:45:21 GMT, Hannes Greule <duke at openjdk.org> wrote:

> After merging master into https://github.com/openjdk/jdk/pull/9862, we encountered test failures (e.g., https://github.com/SirYwell/jdk/actions/runs/4500940829/jobs/7923018438#step:9:2541). The Classfile API tries to read from constant pool index 0 if a MethodParameters attribute has an entry without name.
> 
> The fix is simply using `readUtf8EntryOrNull` instead of `readUtf8Entry`. The related code already correctly handles nullability.
> 
> I didn't find an appropriate test class so I added a new one. Let me know if there's a better place or if the test can be improved somehow.
> 
> As I don't have a JBS account, someone needs to create a bug report there for me. Thanks.

This pull request has now been integrated.

Changeset: a2d3fc83
Author:    SirYwell <hannesgreule at outlook.de>
Committer: Julian Waters <jwaters at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a2d3fc83b0dd7eea38e1dd5898a97d6d7ff60194
Stats:     73 lines in 2 files changed: 71 ins; 0 del; 2 mod

8304837: Classfile API throws IOOBE for MethodParameters attribute without parameter names

Reviewed-by: asotona, jwaters, vromero

-------------

PR: https://git.openjdk.org/jdk/pull/13167


More information about the core-libs-dev mailing list