RFR: 8303530: Add system property for custom JAXP configuration file [v9]
Alan Bateman
alanb at openjdk.org
Sun Apr 30 07:58:24 UTC 2023
On Sun, 30 Apr 2023 07:23:16 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Joe Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>>
>> - Merge branch 'master' into JDK-8303530
>> - Update based on the review meeting on 4/5. Added (duplicated) definitions in jaxp.properties; Rewrote Property Precedence with samples; Other updates.
>> - update javadoc as discussed in the review meeting; add a sample configuration file jaxp.properties; update impl and tests accordingly.
>> - continue support stax.properties at the impl level, though dropped from the spec
>> - change prefix from jdk to java
>> - change prefix from jdk to java; rm zip file that accidentally checked in
>> - update config file description; add a general scope and order section; move value definition for external properties to class description
>> - clean up tests; fix copy&paste error.
>> - 8303530: Add system property for custom JAXP configuration file
>
> src/java.xml/share/classes/module-info.java line 33:
>
>> 31: * JAXP supports the use of a configuration file for the
>> 32: * <a href="#LookupMechanism">Factory Lookup Mechanism</a> and
>> 33: * setting properties that have defined corresponding system properties.
>
> The first sentence of the module description lists the 4 XML APIs and their acronyms. It is immediately followed by a section with title "JAXP Configuration File" which suggests that this is a configuration file for the first API that is listed (JAXP). As I understand it, properties for the streaming API can also be defined in this file. So it might be that a bit more setup is needed in the opening text to make it clearer that this is the configuration file for all of the APIs.
One other thing to say on this is that jaxp.properties has "XML Library (java.xml) Configuration File" at the top of the file, maybe that could be used in the module description instead of "JAXP Configuration File".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12985#discussion_r1181183595
More information about the core-libs-dev
mailing list