RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v10]
Wouter Born
duke at openjdk.org
Sun Aug 6 12:30:44 UTC 2023
On Fri, 21 Jul 2023 16:42:25 GMT, Doug Lea <dl at openjdk.org> wrote:
>> This update addresses performance issues across both LinkedTransferQueue and SynchronousQueue by creating a common basis for implementation across them (mainly in LinkedTransferQueue). Pasting from internal doc summary of changes:
>> * * Class DualNode replaces Qnode, with fields and methods
>> * that apply to any match-based dual data structure, and now
>> * usable in other j.u.c classes. in particular, SynchronousQueue.
>> * * Blocking control (in class DualNode) accommodates
>> * VirtualThreads and (perhaps virtualized) uniprocessors.
>> * * All fields of this class (LinkedTransferQueue) are
>> * default-initializable (to null), allowing further extension
>> * (in particular, SynchronousQueue.Transferer)
>> * * Head and tail fields are lazily initialized rather than set
>> * to a dummy node, while also reducing retries under heavy
>> * contention and misorderings, and relaxing some accesses,
>> * requiring accommodation in many places (as well as
>> * adjustments in WhiteBox tests).
>
> Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into JDK-8301341
> - Address more review comments
> - Address review comments
> - nitpicks
> - Merge branch 'openjdk:master' into JDK-8301341
> - Accommodate white-box tests; use consistent constructions; minor improvements
> - Merge branch 'openjdk:master' into JDK-8301341
> - Simplify contention handling; fix test
> - Fix inverted test assert; improve internal documentation; simplify code
> - Merge branch 'openjdk:master' into JDK-8301341
> - ... and 3 more: https://git.openjdk.org/jdk/compare/c456c802...f53cee67
Thanks for making the fixes Doug!
Would it also be possible to backport these fixes to Java 17?
It seems to be a very common issue for openHAB users now that they upgrade to openHAB 4 which requires Java 17.
See: https://community.openhab.org/t/consistent-100-cpu-use-of-safecall-queue-thread/143792
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14317#issuecomment-1666841611
More information about the core-libs-dev
mailing list