RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v3]

[Mark Sheppard]

On Fri, 4 Aug 2023 19:09:58 GMT, Weibing Xiao <duke at openjdk.org> wrote:

>> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if the is an IOException generation when the output stream was flushing the buffer.
>> 
>> Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657.
>
> Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update error message

test/jdk/com/sun/jndi/ldap/SocketCloseTest.java line 62:

> 60:         props.put(Context.PROVIDER_URL, "ldap://localhost:1389/o=example");
> 61:         props.put("java.naming.ldap.factory.socket", CustomSocketFactory.class.getName());
> 62:         try {

this will execute twice: once in the agentvm main and also, as desired, in the test JVM main.
The agentvm main sees a ClassNotFoundException being thrown and then the output of "The socket was not closed. " in the log c.f. other comments and bug comments for further details to avoid execution in agentvm or use of othervm test mode execution

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15143#discussion_r1285675453