RFR: 8313875: Use literals instead of static fields in java.util.Math: twoToTheDoubleScaleUp, twoToTheDoubleScaleDown [v2]

Raffaello Giulietti rgiulietti at openjdk.org
Tue Aug 8 10:03:34 UTC 2023


On Mon, 7 Aug 2023 19:44:48 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Couple of static fields in Math are used only once and can be replaced with literals `0x1p512`/`0x1p-512 `
>
> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8313875: Make fields final in java.util.Math: twoToTheDoubleScaleUp, twoToTheDoubleScaleDown
>   
>   completely remove the fields. Use literals instead.

I know, but that's not an _official_ review from the perspective of the OpenJDK, it's only a GitHub approval.
I find GitHub "reviews" confusing in the context of OpenJDK.
How would my GitHub approval help you in closing this PR?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14875#issuecomment-1669310813


More information about the core-libs-dev mailing list