RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2]

[Lance Andersen]

On Mon, 14 Aug 2023 17:15:21 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> Lance Andersen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into extraHeaders-JDK-8313765
>>  - Minor comment word smithing
>>  - Fix for JDK-8313765
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 1364:
> 
>> 1362:              * As the fields must appear in order, the block size indicates which
>> 1363:              * fields to expect:
>> 1364:              *  0 - May be written out by Ant and Apache Commons Compress Library
> 
> I don't like that `isZip64ExtBlockSizeValid()` still accepts `0` as *valid* input. I think we should fully handle the zero case in `checkZip64ExtraFieldValues()` (also see my comments there).

Hi Volker,

I understand your point and I had done that  previously  but decided I  did not like the flow of the code that way which is why I moved the check.  I prefer to leave it as is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15273#discussion_r1293782309