RFR: 8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder [v3]

Christoph duke at openjdk.org
Tue Aug 15 19:14:12 UTC 2023


On Mon, 14 Aug 2023 22:07:32 GMT, Mandy Chung <mchung at openjdk.org> wrote:

> Since the batch size is 1, I would suggest that `p4.Main` can also load `jdk.internal.module.SystemModules$all` and verify the expected numbers of `subX` methods (one per each module). To find all modules in the image, you can simply do `ModuleFinder.ofSystem().findAll()`.

Thanks for the suggestion. We added now a check in the main class for the number of generated sub methods. We put a fixed number, as we did not get the relation between the number of "require modules" statements and the total number of modules.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15234#issuecomment-1679458565


More information about the core-libs-dev mailing list