RFR: 8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder [v5]

Christoph duke at openjdk.org
Tue Aug 15 19:58:15 UTC 2023


On Tue, 15 Aug 2023 19:51:44 GMT, Christoph <duke at openjdk.org> wrote:

>> Add new test case with sample modules that contains some requires/exports/uses/provides.
>> 
>> We are just unsure if and how we should add some last step of verificaiton with the extracted and decompiled class.
>> 
>> Follow up task from https://github.com/openjdk/jdk/pull/14408
>
> Christoph has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/fix-8311591' into fix-8311591
>    
>    * origin/fix-8311591:
>      Update test/jdk/tools/jlink/dedup/src/m4/p4/Main.java
>      Update test/jdk/tools/jlink/dedup/src/m4/p4/Main.java
>  - Update test/jdk/tools/jlink/dedup/src/m4/p4/Main.java
>    
>    Co-authored-by: Mandy Chung <mandy.chung at oracle.com>
>  - Update test/jdk/tools/jlink/dedup/src/m4/p4/Main.java
>    
>    Co-authored-by: Mandy Chung <mandy.chung at oracle.com>
>  - Reformat, add missing copyright header
>    
>    Remove duplicated module in add mods call
>    
>    Co-authored-by: Oliver Kopp <kopp.dev at gmail.com>

Thanks a lot for your explanation and suggestions! Now we understood this :)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15234#issuecomment-1679515563


More information about the core-libs-dev mailing list