RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v3]

[Vyom Tewari]

On Wed, 16 Aug 2023 23:11:11 GMT, Weibing Xiao <duke at openjdk.org> wrote:

>> Please refer to JDK-8314063.
>> 
>> The failure scenario is due to the setting of connection timeout. It is either too small or not an optimal value for the system. When the client tries to connect to the server with LDAPs protocol. It requires the handshake after the socket is created and connected, but it fails due to connection timeout and leaves the socket open. It is not closed properly due to the exception handling in the JDK code.
>> 
>> The change is adding a try/catch block and closing the socket in the catch block,  and the format of the code got changed consequently.
>
> Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   updated the code according to the review

test/jdk/com/sun/jndi/ldap/LdapSSLHandshakeFailureTest.java line 143:

> 141:     }
> 142: 
> 143:     private static void setKeyStore() {

Overall code changes looks OK to me,  did you consider creating the self signed certificates programmatically and use them in  your test ?. Please  look into the existing javax.net.ssl tests how to do this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15294#discussion_r1296897982