RFR: 4799358: BufferOutputStream.write() should immediately throw IOExcept on closed stream

Chen Liang liach at openjdk.org
Mon Aug 21 15:03:37 UTC 2023


On Mon, 21 Aug 2023 14:50:12 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:

>> src/java.base/share/classes/java/io/FilterOutputStream.java line 209:
>> 
>>> 207:      * @return {@code true} if, and only if, this stream is open
>>> 208:      */
>>> 209:     protected boolean isOpen(){
>> 
>> Adding a protected method to a public class in an exported packages means this is a new  API, it will require discussion, I don't know if you meant to do this or not.
>
> I thought of this ,but i was not 100% sure. I will create CSR first.

You can convert this method, or the `closed` field, to be package-private (default access) instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15361#discussion_r1300236089


More information about the core-libs-dev mailing list