RFR: 8314491: Linux: jexec launched via PATH fails to find java [v3]
David Holmes
dholmes at openjdk.org
Mon Aug 21 21:39:29 UTC 2023
On Mon, 21 Aug 2023 20:30:54 GMT, Vladimir Petko <vpetko at openjdk.org> wrote:
>> src/java.base/unix/native/launcher/jexec.c line 162:
>>
>>> 160: int argi = 0; /* index into old array */
>>> 161: size_t alen = 0; /* length of new array */
>>> 162: int error = 0; /* getJavaPath error */
>>
>> Nit: no need to pre-declare this, just use `int error = getJavaPath(...)`
>
>> Nit: no need to pre-declare this, just use `int error = getJavaPath(...)`
>
> This one was intentional to keep the style consistent =)
The others are more widely used and there is a desire to document their meaning. That isn't necessary for this case, but as I said, just a nit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15343#discussion_r1300672926
More information about the core-libs-dev
mailing list