RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v3]
Mandy Chung
mchung at openjdk.org
Wed Aug 23 20:27:41 UTC 2023
On Wed, 23 Aug 2023 18:12:15 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Mandy Chung has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>>
>> - Replace NO_METHOD_INFO option with StackWalker.Kind enums
>> - Merge branch 'master' of https://github.com/openjdk/jdk into stackwalker-class
>> - clean up
>> - fix trailing whitespace
>> - Merge branch 'master' of https://github.com/openjdk/jdk into stackwalker-class
>> - Update LocalLongHelper.java
>> - clean up
>> - Merge branch 'master' of https://github.com/openjdk/jdk into stackwalker-class
>> - Add StackWalker.Option.NO_METHOD_INFO
>> - Merge branch 'master' of https://github.com/openjdk/jdk into stackwalker-class
>> - ... and 6 more: https://git.openjdk.org/jdk/compare/ce1ded1a...434d90cb
>
> src/java.base/share/classes/java/lang/StackFrameInfo.java line 38:
>
>> 36: SharedSecrets.getJavaLangInvokeAccess();
>> 37:
>> 38: private final boolean retainClassRef;
>
> Shouldn't `private final boolean retainClassRef` move to ClassFrameInfo? Isn't it strange that CLASS_INFO still implies RETAIN_CLASS_REFERENCE?
I was planning to move `retainClassRef` to `ClassFrameInfo` as a bit set in the `flags` field. Thanks for catching this and reminding me to do that. Now updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15370#discussion_r1303501735
More information about the core-libs-dev
mailing list