Integrated: 8308042: [macos] Developer ID Application Certificate not picked up by jpackage if it contains UNICODE characters

[Alan Snyder]

What’s the point of reviewing if the reviews are ignored?



> On Aug 23, 2023, at 1:25 PM, Alexander Matveev <almatvee at openjdk.org> wrote:
> 
> On Tue, 22 Aug 2023 21:59:50 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
> 
>> - Added support for certificates with UNICODE characters.
>> - Added new approach to find certificate using "security" and "openssl" commands. Just "security" does not works, since it can truncate certificates name. "security" is used to dump certificate in PEM format and then "openssl" to get subject form PEM.
>> - New approach works with UNICODE and ASCII, but I left old approach to avoid regressions. If old approach fails to find certificate (UNICODE or very long subject case) we will fallback to new approach.
>> - Added tests for UNICODE to SigningAppImageTest and SigningPackageTest.java. I do not think that we need to cover other signing cases for UNICODE.
> 
> This pull request has now been integrated.
> 
> Changeset: 57a322da
> Author:    Alexander Matveev <almatvee at openjdk.org>
> URL:       https://git.openjdk.org/jdk/commit/57a322da9bf6aac98e834516728fb6da1c18e7aa
> Stats:     444 lines in 11 files changed: 248 ins; 60 del; 136 mod
> 
> 8308042: [macos] Developer ID Application Certificate not picked up by jpackage if it contains UNICODE characters
> 
> Reviewed-by: asemenyuk
> 
> -------------
> 
> PR: https://git.openjdk.org/jdk/pull/15394
>