RFR: 8263135: unique_ptr should not be used for types that are not pointers
Julian Waters
jwaters at openjdk.org
Fri Aug 25 01:47:38 UTC 2023
On Thu, 24 Aug 2023 20:02:23 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
> > I'm wondering how MSVC is compiling without the header
>
> For older MSVC it picks unique_ptr from https://github.com/openjdk/jdk/blob/2624324ac216aadc938a870075f6fad287fedf05/src/jdk.jpackage/share/native/common/kludge_c%2B%2B11.h
Hmm, I just checked in that file, and it seems like the kludge unique_ptr is only defined for gcc, with no case that enables it for MSVC? (On top of that the gcc conditional is also not spelled correctly)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/2858#issuecomment-1692634683
More information about the core-libs-dev
mailing list