RFR: 8315004: Runtime.halt() debug logging
Alan Bateman
alanb at openjdk.org
Fri Aug 25 09:52:11 UTC 2023
On Fri, 25 Aug 2023 09:37:47 GMT, Masanori Yano <myano at openjdk.org> wrote:
> I want to add a log output similar to JDK-8301627 to Runtime.halt().
> To avoid double logging of Runtime.exit(), add a flag to indicate whether logging was done, and fix it so that logging is done only once.
> Could someone please review this fix?
I think you may have missed the comment in the JBS issue. Logging means running potentially arbitrary code, doing this at Runtime.halt time is problematic. I thought the conclusion from the work on Runtime.exit was not to log in Runtime.halt?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15426#issuecomment-1693095419
More information about the core-libs-dev
mailing list