RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v2]

Jaikiran Pai jpai at openjdk.org
Fri Aug 25 11:14:11 UTC 2023


On Thu, 24 Aug 2023 10:54:19 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

>> Recursive initialization calls possible during loading of LoggerFinder service.  
>> 
>> This fix detects the recursive call and returns a temporary LoggerFinder that is backed by a lazy logger. Automated test case developed to simulate loading of an external LoggerFinder service while also having other threads poke System.getLogger during this framework initialization.
>
> Sean Coffey has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Improve test coverage
>  - Incorporate review comments from Daniel

test/jdk/java/lang/System/LoggerFinder/SignedLoggerFinderTest/SignedLoggerFinderTest.java line 109:

> 107:                 Boolean.parseBoolean(System.getProperty("mutliThreadLoad", "false"));
> 108:             boolean withCustomLoggerFinder =
> 109:                 Boolean.parseBoolean(System.getProperty("withCustomLoggerFinder", "false"));

Nit - these two calls can be replaced with `Boolean.getBoolean("<syspropname>")`. If you however want to use this current form, that's fine too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15404#discussion_r1305525527


More information about the core-libs-dev mailing list