Integrated: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection

Weibing Xiao duke at openjdk.org
Fri Aug 25 12:23:36 UTC 2023


On Tue, 15 Aug 2023 17:30:54 GMT, Weibing Xiao <duke at openjdk.org> wrote:

> Please refer to JDK-8314063.
> 
> The failure scenario is due to the setting of connection timeout. It is either too small or not an optimal value for the system. When the client tries to connect to the server with LDAPs protocol. It requires the handshake after the socket is created and connected, but it fails due to connection timeout and leaves the socket open. It is not closed properly due to the exception handling in the JDK code.
> 
> The change is adding a try/catch block and closing the socket in the catch block,  and the format of the code got changed consequently.

This pull request has now been integrated.

Changeset: f2383b3c
Author:    Weibing Xiao <weibing.xiao at oracle.com>
Committer: Aleksei Efimov <aefimov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f2383b3cbd1096f0b38e89a3d876da2217511f11
Stats:     357 lines in 3 files changed: 290 ins; 42 del; 25 mod

8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection

Reviewed-by: aefimov, msheppar

-------------

PR: https://git.openjdk.org/jdk/pull/15294


More information about the core-libs-dev mailing list