RFR: JDK-8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children
Thomas Stuefe
stuefe at openjdk.org
Tue Aug 29 08:07:16 UTC 2023
On Tue, 29 Aug 2023 07:51:59 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> We have some failures in TreeTest.java where the expected number of child processes is differing from what we really get. It would be good to have more output to analyze these cases.
Looks good. Small nit inline.
test/jdk/java/lang/ProcessHandle/TreeTest.java line 451:
> 449: subprocesses.stream().map(p -> p.pid())
> 450: .collect(Collectors.toList()));
> 451:
Small nit: I would not reuse the variable, but use an own one.
-------------
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15466#pullrequestreview-1599761848
PR Review Comment: https://git.openjdk.org/jdk/pull/15466#discussion_r1308381401
More information about the core-libs-dev
mailing list