RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v7]

[Daniel Fuchs]

On Tue, 29 Aug 2023 16:39:56 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/StackWalker.java line 73:
>> 
>>> 71:  * <p>1. To find the first caller filtering a known list of implementation class:
>>> 72:  * {@snippet lang="java" :
>>> 73:  *     StackWalker walker = StackWalker.getInstance(Option.DROP_METHOD_INFO, Option.RETAIN_CLASS_REFERENCE);
>> 
>> Would this read better as "filtering **out** a known list of implementation **classes**" ?
>
> how about "s/filtering/excluding"?

Yes - that's better.

>> src/java.base/share/classes/java/lang/StackWalker.java line 98:
>> 
>>> 96:      *
>>> 97:      * <p> The information of a {@code StackFrame} available is determined by the
>>> 98:      * {@linkplain Option stack walking options} of a stack walker.
>> 
>> Would this read better as "The information available from a {@code StackFrame} is determined ... "?
>
> What about "Stack walker options configure the stack frame information obtained by a StackWalker." - the first sentence from the Option javadoc and use it in the class spec of StackWalker and StackFrame.

Sounds good!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15370#discussion_r1309117609
PR Review Comment: https://git.openjdk.org/jdk/pull/15370#discussion_r1309116727