RFR: 8314236: Overflow in Collections.rotate [v8]

[Nikita Sakharin]

On Tue, 29 Aug 2023 03:02:56 GMT, Stuart Marks <smarks at openjdk.org> wrote:

>> Nikita Sakharin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   fix overflow in Collections.rotate and write tests
>
> (The bot has already admonished you about avoiding rebasing. In practice merging works well and is helpful so that reviewers can see incremental changes.)
> 
> The additional test cases look good. Sorry I forgot to mention this previously: it would be good to have a comment in the test that says that the test is _only_ testing the index computations and not the actual rotation of elements.
> 
> Meanwhile, I'll pull in the changes from your branch and run them through our internal build system, which is more reliable (and comprehensive) than GHA.

@stuart-marks

Thank you for your review!

I added comment for the test.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15270#issuecomment-1698051561