RFR: 6333341: [BI] Doc: java.text.BreakIterator class specification is unclear [v2]
Naoto Sato
naoto at openjdk.org
Wed Aug 30 17:22:14 UTC 2023
On Tue, 29 Aug 2023 20:09:37 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR and [CSR ](https://bugs.openjdk.org/browse/JDK-8314974)which clarifies behavior for BreakIterator instances when text has not been set.
>>
>> For example, calling `BreakIterator.getWordInstance().next();` has an ambiguous result.
>> A boundary searching operation was called but no text was supplied. Is the result an exception, 0, -1 (BreakIterator.DONE), or something else? In reality, the operation will be performed on any empty string.
>>
>>
>> This change makes it apparent that failing to set the text will cause the BreakIterator instance to default to a `StringCharacterIterator` with an empty string (equivalent to calling setText("")).
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> Use implNote tag
LGTM. Reviewed the CSR as well.
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15422#pullrequestreview-1603171201
More information about the core-libs-dev
mailing list