RFR: 8233160: Add java.vendor.url.bug to list of recognized standard system properties
Alan Bateman
alanb at openjdk.org
Thu Aug 31 07:37:59 UTC 2023
On Thu, 31 Aug 2023 06:53:45 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this change which proposes to address https://bugs.openjdk.org/browse/JDK-8233160?
>
> It has been noted in https://bugs.openjdk.org/browse/JDK-8232753 that:
>
>> The java.vendor.url.bug property has been defined by every Sun/Oracle JDK going all the way back to JDK 5 (and possibly earlier; JDK 5 is the oldest release that I can still run on my development machine). Yet, it's never been specified.
>
> The OpenJDK builds too by default set a value for this system property.
>
> The commit in this PR updates the javadoc of `System.getProperties()` to include this system property in the list of specified properties. Additionally, the `test/jdk/java/lang/System/PropertyTest.java` test has been updated to verify that this property is indeed available in the Properties returned by `System.getProperites()`.
>
> I'll create a CSR shortly for this change.
No objection to making this a standard property, I just wonder if it should be optional (like java.vendor.version), and whether the value must be parsable as a URL. The question on whether the value can be interpreted as a URL applies to the exiting java.vendor.url property too.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15504#issuecomment-1700518322
More information about the core-libs-dev
mailing list