RFR: 8313983: jmod create --target-platform should replace existing ModuleTarget attribute

Mandy Chung mchung at openjdk.org
Thu Aug 31 16:50:01 UTC 2023


On Thu, 31 Aug 2023 12:13:40 GMT, Adam Sotona <asotona at openjdk.org> wrote:

> ModuleTarget and ModuleResolution attributes were flagged as 'allow multiple' in the Classfile API.
> This patch removed the flags and allows at most one instance of each attribute.
> 
> Please review.
> 
> Thanks,
> Adam

Would you consider documenting in the javadoc of XXXAttribute in the ClassFile API if it allows multiple?   It will make clear to the readers.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15514#issuecomment-1701404915


More information about the core-libs-dev mailing list