RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed [v3]
Jaikiran Pai
jpai at openjdk.org
Fri Dec 1 12:44:19 UTC 2023
On Fri, 1 Dec 2023 12:09:14 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Hello Stefan, this is just for a tiny optimization to prevent multiple reads (in the same thread) on the `volatile` field `processExitCode` in this method.
>
> I don't think such an optimization is needed here. This is not performance-critical code.
That's true. I've now updated the PR to keep it simple and remove that optimization.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16919#discussion_r1412058767
More information about the core-libs-dev
mailing list