RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v5]

Magnus Ihse Bursie ihse at openjdk.org
Fri Dec 1 16:39:15 UTC 2023


On Fri, 1 Dec 2023 16:35:31 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Yes. It still failed.
>
> You need to expand this logic to cover more instances. See e.g. lib-ffi.m4 for inspiration.
> 
> Basic flow:
> * if user has specified libsleef root with argument, check both lib/ and lib64/ under that root.
> * if user has not specified libsleef root, and we have no SYSROOT, try PKG_CHECK
> * Otherwise, look in well-known directories which is $SYSROOT/usr/[local/]lib[64].

also, ideally, you will add the corresponding specific overrides like in ffi:

  AC_ARG_WITH(libffi-include, [AS_HELP_STRING([--with-libffi-include],
      [specify directory for the libffi include files])])
  AC_ARG_WITH(libffi-lib, [AS_HELP_STRING([--with-libffi-lib],
      [specify directory for the libffi library])])

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16234#discussion_r1412341451


More information about the core-libs-dev mailing list