RFR: 8321131: Console read line with zero out should zero out underlying buffer in JLine
Iris Clark
iris at openjdk.org
Fri Dec 1 19:45:55 UTC 2023
On Fri, 1 Dec 2023 18:24:48 GMT, Naoto Sato <naoto at openjdk.org> wrote:
> This is the fix to JLine, which makes it on par with the built-in Console fix ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)).
Marked as reviewed by iris (Reviewer).
src/jdk.internal.le/share/classes/jdk/internal/org/jline/JdkConsoleProviderImpl.java line 114:
> 112: return null;
> 113: } finally {
> 114: jline.zeroOut();
The location of the `jline `declaration at new line 134 is unfortunate, but not a problem this PR needs to resolve. The location makes sense if it was only used in `initJLineIfNeeded()` at some point in the past.
-------------
PR Review: https://git.openjdk.org/jdk/pull/16930#pullrequestreview-1760456573
PR Review Comment: https://git.openjdk.org/jdk/pull/16930#discussion_r1412504396
More information about the core-libs-dev
mailing list