RFR: 8321124: java/util/stream/GatherersTest.java times out [v2]

Viktor Klang vklang at openjdk.org
Fri Dec 1 22:16:47 UTC 2023


On Fri, 1 Dec 2023 22:06:14 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> Renames GatherersTest to BuiltInGatherersTest for easier deduplication of GathererTest.
>> 
>> Fixes a test ordering issue in testMapConcurrentAPIandContract().
>> 
>> Adding increased maxOutputSize for Gatherer-related tests to improve debuggability.
>> 
>> Lowering the composition threshold of GathererTest.testMassivelyComposedGatherers to 256 to avoid SOE on low-specc:ed machines.
>
> Viktor Klang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Only run the cancellation tests for mapConcurrent for the shorter streams to conserve resources

test/jdk/java/util/stream/BuiltInGatherersTest.java line 257:

> 255:         // Test cancellation after exception during processing
> 256:         // Only use reasonably sized streams to avoid excessive thread creation
> 257:         if (config.streamSize > 2 && config.streamSize < 100) {

@AlanBateman Decided to not run the cancellation tests for the larger streams as it creates a bunch of extra resource usage which makes GHA really unhappy.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16928#discussion_r1412617167


More information about the core-libs-dev mailing list