RFR: 8321131: Console read line with zero out should zero out underlying buffer in JLine [v2]

Iris Clark iris at openjdk.org
Fri Dec 1 22:26:32 UTC 2023


On Fri, 1 Dec 2023 21:24:47 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> This is the fix to JLine, which makes it on par with the built-in Console fix ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)).
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   moved instance fields at the top of the class

Marked as reviewed by iris (Reviewer).

src/jdk.internal.le/share/classes/jdk/internal/org/jline/JdkConsoleProviderImpl.java line 72:

> 70:         private final Terminal terminal;
> 71:         private volatile LineReader jline;
> 72: 

Relocation looks good.  Thanks!

-------------

PR Review: https://git.openjdk.org/jdk/pull/16930#pullrequestreview-1760648178
PR Review Comment: https://git.openjdk.org/jdk/pull/16930#discussion_r1412624704


More information about the core-libs-dev mailing list