Integrated: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
Leonid Mesnik
lmesnik at openjdk.org
Sat Dec 2 03:00:46 UTC 2023
On Fri, 1 Dec 2023 00:58:57 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
> Description of problem and propsed fix from @plummercj
> '
> In test/failure_handler/src/share/conf/mac.properties we have:
>
> process.top.app=top
> process.top.args=-l 1
>
> So top is run with the "-l 1" args, causing it to do one iteration and then exit. Unfortunately the first iteration always shows all 0's for CPU usage. If you do at least 2 iterations, you do see the proper CPU usage on the 2nd iteration. The user just needs to know to scroll down to see it. I suggest we start using "-l 2" unless someone has a better idea.
>
> BTW, for proper CPU usage you can instead look at the failure handler "ps" output, which seems to be correct. But it is nice to have "top" produce the correct output so all the CPU hogs are at the top of the list.
> '
>
> I verified that top report contains now 2 samples.
This pull request has now been integrated.
Changeset: 8be3e392
Author: Leonid Mesnik <lmesnik at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/8be3e39220cd64521f4e370011958e17e5fdeaf3
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
Reviewed-by: cjplummer, jpai
-------------
PR: https://git.openjdk.org/jdk/pull/16915
More information about the core-libs-dev
mailing list