RFR: 8321124: java/util/stream/GatherersTest.java times out [v2]

Viktor Klang vklang at openjdk.org
Mon Dec 4 08:46:50 UTC 2023


On Sun, 3 Dec 2023 09:26:45 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Viktor Klang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Only run the cancellation tests for mapConcurrent for the shorter streams to conserve resources
>
> test/jdk/java/util/stream/BuiltInGatherersTest.java line 272:
> 
>> 270:                                     case 1 -> {
>> 271:                                         throwerReady.countDown();
>> 272:                                         awaitSensibly(initiateThrow);
> 
> 20s might not be enough to wait for the count down when running with a debug build, -Xcomp, ...  I would be tempted to just have it wait indefinitely. If there is an issue then jtreg will timeout the test.

I'll switch it back do indefinite wait and let jtreg report the timeout instead as you suggested. having bounded timeouts made debugging easier so I left that facility in in case the future has more timeouts in it...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16928#discussion_r1413535985


More information about the core-libs-dev mailing list