RFR: 8321124: java/util/stream/GatherersTest.java times out [v3]

Viktor Klang vklang at openjdk.org
Mon Dec 4 14:20:43 UTC 2023


On Mon, 4 Dec 2023 14:11:34 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> Splits GatherersTest out to distinct files per built-in gatherer
>> 
>> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on the ProblemList.
>> 
>> Adding increased maxOutputSize for Gatherer-related tests to improve debuggability.
>> 
>> Lowering the composition threshold of GathererTest.testMassivelyComposedGatherers to 256 to avoid SOE on low-specc:ed machines.
>
> Viktor Klang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Maintainability, correctness, and stability overhaul of Gatherers tests

test/jdk/java/util/stream/GatherersFoldTest.java line 81:

> 79:             config.stream()
> 80:                     .sequential()
> 81:                     .reduce(0L, (acc, next) -> acc + next,(l, r) -> {

Modified this test to accumulate to a Long instead of appending to a String to reduce the allocation overhead of the test case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16928#discussion_r1413938440


More information about the core-libs-dev mailing list