RFR: 8321270: Virtual Thread.yield consumes parking permit

Alan Bateman alanb at openjdk.org
Mon Dec 4 19:27:59 UTC 2023


When a virtual thread continues after Thread.yield it currently consumes thread's parking permit. This is an oversight, the parking permit should only be consumed when continuing after park.

The changes are straight-forward. The internal "RUNNABLE" state is replaced with UNPARKED and YIELDED state, effectively encoding the previous state. So for the most part, it's just replacing the usages of RUNNABLE. The additional states require refactoring tryGetStackTrace, this is the method that is used for Thread::getStackTrace when the virtual thread is unmounted. It is also changed to not not swallow the REE if the reesubmit fails (tryStackTrace has to resubmit as the task for the thread may run, or the thread unparked, while "suspended" and sampling its stack trace). The changes are a subset of larger changes in the loom repo, future PRs will propose to bring in other changes to get main line up to date.

For testing the existing ThreadAPI has new test cases.

Testing: test1-5. This includes the JVMTI tests as it maps the thread states to JVMTI thread states.

-------------

Commit messages:
 - Leave onPinned to another PR
 - Initial commit

Changes: https://git.openjdk.org/jdk/pull/16953/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16953&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8321270
  Stats: 150 lines in 4 files changed: 79 ins; 19 del; 52 mod
  Patch: https://git.openjdk.org/jdk/pull/16953.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16953/head:pull/16953

PR: https://git.openjdk.org/jdk/pull/16953


More information about the core-libs-dev mailing list