RFR: 8321124: java/util/stream/GatherersTest.java times out [v5]

Andrey Turbanov aturbanov at openjdk.org
Tue Dec 5 19:19:36 UTC 2023


On Tue, 5 Dec 2023 14:55:02 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> Splits GatherersTest out to distinct files per built-in gatherer
>> 
>> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on the ProblemList.
>> 
>> Adding increased maxOutputSize for Gatherer-related tests to improve debuggability.
>> 
>> Lowering the composition threshold of GathererTest.testMassivelyComposedGatherers to 256 to avoid SOE on low-specc:ed machines.
>
> Viktor Klang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addressing review feedback: improving test coverage and debuggability

test/jdk/java/util/stream/GatherersMapConcurrentTest.java line 254:

> 252:                                     fail("Unexpected!");
> 253:                                 }
> 254:                                 while(tasksWaiting.getQueueLength() < tasksToCancel) {

Suggestion:

                                while (tasksWaiting.getQueueLength() < tasksToCancel) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16928#discussion_r1416171352


More information about the core-libs-dev mailing list