RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed [v3]

Stefan Karlsson stefank at openjdk.org
Wed Dec 6 09:21:46 UTC 2023


On Wed, 6 Dec 2023 01:56:46 GMT, David Holmes <dholmes at openjdk.org> wrote:

> FWIW exitCode out numbers exitValue in source code 3:1 (and > 5:1 in test code).

That might be the case, but both the called function returning the value and the function we are changing uses the name exitValue. It seems irrelevant that other places in the code uses exitCode.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16919#issuecomment-1842489162


More information about the core-libs-dev mailing list