RFR: 8321248: ClassFile API ClassModel::verify is inconsistent with the rest of the API

[Maurizio Cimadamore]

On Mon, 4 Dec 2023 11:12:37 GMT, Adam Sotona <asotona at openjdk.org> wrote:

> ClassFile API `ClassModel::verify` accepts `ClassHierarchyResolver` as an optional argument and does not respect `ClassFile.ClassHierarchyResolverOption` of the actual context.
> Parsing, building and transforming take options from the actual `ClassFile` context and verification should follow the same API pattern.
> 
> This patch removes `ClassModel::verify` methods and introduces new top level methods:
> 
> List<VerifyError> ClassFile::verify(ClassModel model);
> List<VerifyError> ClassFile::verify(byte[] bytes);
> List<VerifyError> ClassFile::verify(Path path);
> 
> 
> Impact of the API change is minimal as the API has not been released yet.
> 
> Please review.
> 
> Thanks,
> Adam

test/jdk/jdk/classfile/VerifierSelfTest.java line 62:

> 60: 
> 61:     @Test
> 62:     void testFailedDump() throws IOException {

Why is this removed?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16947#discussion_r1416985296